Fix collator_rulebased_fuzzer: stop masking errors by resetting UErrorCode#3920
Open
OwenSanzas wants to merge 1 commit intounicode-org:mainfrom
Open
Fix collator_rulebased_fuzzer: stop masking errors by resetting UErrorCode#3920OwenSanzas wants to merge 1 commit intounicode-org:mainfrom
OwenSanzas wants to merge 1 commit intounicode-org:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After each ICU API call, the fuzzer resets
status = U_ZERO_ERRORand continues execution regardless of whether the previous call failed. This masks errors and allows the fuzzer to call subsequent APIs on objects in an error state.For example, if
getVariableTop(status)fails, the fuzzer resets status and proceeds to callgetCollationKey(),getRules(), etc. on a potentially invalid collator state.Fix: Check
U_FAILURE(status)after each API call and return early on error, instead of blindly resetting the error code.Coverage comparison (60 seconds, empty seed corpus, ASan, libFuzzer)
Note: The edge coverage improvement may partially be due to fuzzer randomness, but confirms the fix does not regress coverage.